linux-kernel - Re: [GIT PULL] please pull infiniband.git for-linus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1199402314.6854.0.camel@obelisk.thedillows.org>
Date:	Thu, 03 Jan 2008 18:18:34 -0500
From:	Dave Dillow <dillowda@...l.gov>
To:	Rik van Riel <riel@...hat.com>
Cc:	Roland Dreier <rdreier@...co.com>, general@...ts.openfabrics.org,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] please pull infiniband.git for-linus

On Thu, 2008-01-03 at 18:11 -0500, Rik van Riel wrote:
> On Thu, 03 Jan 2008 15:20:09 -0500
> David Dillow <dillowda@...l.gov> wrote:
> 
> > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> > index 950228f..6e7e3c8 100644
> > --- a/drivers/infiniband/ulp/srp/ib_srp.c
> > +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> > @@ -423,8 +423,8 @@ static void srp_remove_work(struct work_struct *work)
> >  	list_del(&target->list);
> >  	spin_unlock(&target->srp_host->target_lock);
> >  
> > -	srp_remove_host(target->scsi_host);
> >  	scsi_remove_host(target->scsi_host);
> > +	srp_remove_host(target->scsi_host);
> >  	ib_destroy_cm_id(target->cm_id);
> >  	srp_free_target_ib(target);
> >  	scsi_host_put(target->scsi_host);
> 
> These last two look suspicious.  Are you freeing target before
> freeing target->scsi_host or does the code simply not do what
> it looks like it's doing? :)
> 
> (no, I haven't looked at the IB code - I'm probably wrong)

srp_free_target_ib() just frees the buffers for the target, and
scsi_host_put() does the actual cleanup once the refcount drops to zero.

Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/