lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Jan 2008 19:00:00 -0800 From: Harvey Harrison <harvey.harrison@...il.com> To: Masami Hiramatsu <mhiramat@...hat.com> Cc: Ingo Molnar <mingo@...e.hu>, qbarnes <qbarnes@...il.com>, "H. Peter Anvin" <hpa@...or.com>, LKML <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Ananth N Mavinakayanahalli <ananth@...ibm.com>, Jim Keniston <jkenisto@...ibm.com>, davem@...emloft.net, Keshavamurthy Anil S <anil.s.keshavamurthy@...el.com> Subject: Re: [PATCH] x86: Use is_kprobe_fault to better match usage On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote: > Hi Harvey, > > Harvey Harrison wrote: > > Currently the notify_page_fault helper is used to test it the page > > fault was caused by a kprobe causing an early return from do_page_fault. > > > > Change the name of the helper to is_kprobe_fault to match the usage and > > remove the preempt_disable/enable pair around kprobe_running() with an > > explicit test for preemption. The idea for this comes from a patch > > by Quentin Barnes to kprobes.c > > Sure, that's right. > However, since other architectures also have notify_page_fault(), > I think all of those code might better be changed same time for > maintainability. > How about a static inline in linux/kprobes.h with a big comment above about when/why the !preemptible() check is sufficient? Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists