lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080104085845.GD28740@elte.hu>
Date:	Fri, 4 Jan 2008 09:58:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <ak@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the
	spurious irq debugging state


* Andi Kleen <ak@...e.de> wrote:

> This is useful to debug problems with interrupt handlers that return 
> sometimes IRQ_NONE.

agreed.

A style error slipped in, please fix it:

> +static int irq_spurious_read(char *page, char **start, off_t off,
> +				  int count, int *eof, void *data)
> +{
> +	struct irq_desc *d = &irq_desc[(long) data];
> +	return sprintf(page, "count %u\n"
> +			     "unhandled %u\n"

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ