| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080104114832.GA4114@elf.ucw.cz> Date: Fri, 4 Jan 2008 12:48:32 +0100 From: Pavel Machek <pavel@....cz> To: Yi Yang <yi.y.yang@...el.com> Cc: linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device Hi! > If a device can't support wakeup, its /sys/devices/.../power/wakeup output is > empty, this is confusing, a user doesn't know if it supports wakeup feature > unless he/she read the ralated source code, for this case, it is more > reasonable to output "unsupported". Otherwise, no matter what value the user > sets to /sys/devices/.../power/wakeup, the result is the same: Invalid argument, > so the user doesn't know why. > > This patch changes empty output to "unsupported" in order that a user knows > wakeup feature isn't supported by this device when he/she > 'cat /sys/devices/.../power/wakeup', please consider to apply, > thanks. What about simply removing "wakuep" file if wakeup is not supported? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists