linux-kernel - Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table II

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801041338.08093.ak@suse.de>
Date:	Fri, 4 Jan 2008 13:38:07 +0100
From:	Andi Kleen <ak@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	peterz@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table II

On Friday 04 January 2008 10:00:52 Ingo Molnar wrote:
> 
> * Andi Kleen <ak@...e.de> wrote:
> 
> > On x86-64 there are several memory allocations before bootmem. To 
> > avoid them stomping on each other they used to be all hard coded in 
> > bad_area(). Replace this with an array that is filled as needed.
> > 
> > This cleans up the code considerably and allows to expand its use.
> 
> this code introduces a number of style errors that make the code harder 
> to read and follow. Please fix them.

I reviewed the code now and I honestly don't see any "style errors" so I don't
know how to change it.

-Andi 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/