linux-kernel - [PATCH] Change a WARN message in checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080104134535.6689872a@paolo-desktop>
Date:	Fri, 4 Jan 2008 13:45:35 +0100
From:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
To:	andyw@...ibm.com, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] Change a WARN message in checkpatch

Hi Andy,
I just started using checkpatch and I was confused by the following WARN message:

	no space between function name and open parenthesis

I thought the probelm was that a space was missing while the truth is the opposite.

How about the following patch?


--- checkpatch.pl.old	2008-01-04 13:37:51.000000000 +0100
+++ checkpatch.pl	2008-01-04 13:37:24.000000000 +0100
@@ -1117,7 +1117,7 @@
 		while ($line =~ /($Ident)\s+\(/g) {
 			if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
 		            $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
-				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
+				WARN("don't put a space between function name and open parenthesis '('\n" . $herecurr);
 			}
 		}
 # Check operator spacing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/