linux-kernel - Re: [PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080104132328.GA27330@elte.hu>
Date:	Fri, 4 Jan 2008 14:23:28 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] This patch to profile.c fixes a few errors reported by
	checkpatch.pl


* Paolo Ciarrocchi <paolo.ciarrocchi@...il.com> wrote:

> > i.e. take the implicit assignment out of the condition. (it's easy 
> > to mistake it for '==' while reviewing the code and forgetting about 
> > the assignment's side-effect)
> 
> OK, thanks.
> 
> Is the following correct?
> 
> Before:
>  if (!(entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)))
> 
> After:
> entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)
> if (!entry)
> 
> BTW, how can i compile only the profile.c file?

make kernel/profile.o

> I would like to verify that my changes (now I'm at total: 2 errors, 1 
> warnings, 599 lines checked) doesn't impact on the compiled code?

check out:

 http://people.redhat.com/mingo/misc/q-size-obj-compare

which does a size and md5 comparison. (assuming your patch is in a quilt 
queue) But if you reorder symbols (due to the EXPORT_SYMBOL moving) the 
md5 might differ. (but size should still be the same)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/