linux-kernel - Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <477E47C2.3050700@linux.intel.com>
Date:	Fri, 04 Jan 2008 06:50:42 -0800
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	akpm@...ux-foundation.org, olof@...om.net
Subject: Re: [patch 2/2] Add the end-of-trace marker and the module list to
 WARN_ON()

Heiko Carstens wrote:
> On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote:
>> Another issue is that, unlike oopses, WARN_ON() doesn't currently printk
>> the helpful "cut here" line, nor the "end of trace" marker.
>> Now that WARN_ON() is out of line, the size increase due to this is
>> minimal and it's worth adding.
>>
>> +static void print_oops_end_marker(void)
>> +{
>> +	init_oops_id();
>> +	printk(KERN_WARNING "---[ end trace %016llx ]---\n",
>> +		(unsigned long long)oops_id);
>> +}
> 
> There is also lib/bug.c which prints the "cut here" line but not the
> "end of trace" line. 

it ends up printing the "end of trace" line as part of the oops_exit() call
 >

> Also it prints whatever it prints with a different
> printk level.

as it should.. WARN_ON()'s are warnings so get KERN_WARNING ;-)

> Quite a few architectures use lib/bug.c also for WARN_ONs.

is this still the case after Olof's patch?

> Maybe all the code should be in one place so it doesn't diverge all the
> time?

it's actually ok as is.. the core tracing code lives in panic.c; lib/bug.c is just a few helpers
for BUG().. for WARN_ON() there is a lot less to help
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/