linux-kernel - Re: [patch 1/2] move WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080104160015.GA29770@lixom.net>
Date:	Fri, 4 Jan 2008 10:00:15 -0600
From:	Olof Johansson <olof@...om.net>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Arjan van de Ven <arjan@...ux.intel.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mpm@...enic.com, paulus@...ba.org
Subject: Re: [patch 1/2] move WARN_ON() out of line

On Fri, Jan 04, 2008 at 08:41:49AM +0100, Ingo Molnar wrote:
> 
> * Arjan van de Ven <arjan@...ux.intel.com> wrote:
> 
> > This patch build on top of Olof's patch that introduces __WARN, and 
> > places the slowpath out of line. It also uses Ingo's suggestion to not 
> > use __FUNCTION__ but to use kallsyms to do the lookup; this saves a 
> > ton of extra space since gcc doesn't need to store the function string 
> > twice now:
> >
> > 3936367  833603  624736 5394706  525112 vmlinux.before
> > 3917508  833603  624736 5375847  520767 vmlinux-slowpath
> >
> > 15Kb savings...
> 
> hey, cool!
> 
> Acked-by: Ingo Molnar <mingo@...e.hu>
> 
> i'm wondering how we could put this into x86.git to get it tested some 
> more. Olof's patch touches other architectures so it's not really 
> appropriate. Maybe a portion of Olof's patch could be applied to make 
> your patch apply cleanly?

My base patch only touches other architectures to remove the no longer
needed HAVE_ARCH_BUG. Given the new ifdef in bug.h, there's nothing
functional that breaks if they're left in (i.e. split up in two
patches).

The only problem with merging it up the x86 path is that the powerpc
patch that builds on it would need to be ordered after the x86 merge
(in mm etc), or it'll cause build breaks. Keeping it in -mm is nice in
that way since Andrew could sequence them right when sending to Linus.

Easiest of all might be to get an Acked-by from Paul on the powerpc patch,
and merge it all up through x86.git?

(Paul: This is powerpc-switch-to-generic-warn_on-bug_on.patch in -mm
I'm talking about).

-Olof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/