linux-kernel - Re: [PATCH] profile: further Codying Style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d8e3fd30801040918m4b928eebmb37e2bce5425715@mail.gmail.com>
Date:	Fri, 4 Jan 2008 20:48:59 +0330
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Sam Ravnborg" <sam@...nborg.org>
Cc:	mingo@...te.hu, "Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] profile: further Codying Style fixes

On 1/4/08, Sam Ravnborg <sam@...nborg.org> wrote:
> > @@ -408,9 +406,8 @@ void profile_hits(int type, void *__pc, unsigned int
> nr_hits)
> >  	pc = ((unsigned long)__pc - (unsigned long)_stext) >> prof_shift;
> >  	atomic_add(nr_hits, &prof_buffer[min(pc, prof_len - 1)]);
> >  }
> > -#endif /* !CONFIG_SMP */
> > -
> >  EXPORT_SYMBOL_GPL(profile_hits);
> > +#endif /* !CONFIG_SMP */
>
> The symbol is now not exported for non-SMP builds which is a change in
> functionality.
> And thats not acceptable for pure clean-up patches.

Right, i'll update the patch.
Thanks Sam.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/