linux-kernel - Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table II

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Jan 2008 18:51:28 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Andi Kleen <ak@...e.de>
Cc:	Ingo Molnar <mingo@...e.hu>, peterz@...radead.org,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table II

> 
> In a minor way -- it is far less important than let's say good high level
> comments or clear code flow. 
> 
> e.g. this patch imho is a major improvement in code clarity and logic
> and makes previously quite fragile code much simpler and more approachable
> and easier changeable (I can say this because I was responsible for the 
> original mess -- only excuse is that it has grown over time). And then when 
> people don't see these advantages and just talk about tabs<->spaces that is 
> quite annoying.

It is great to have all the obvious style issues fixed no matter how much
the code clarity and logic is improved. For the simple reason that with
obvious coding style issues fixed you do not get distracted.

And I do not understand why people has any problem with that when we talk
about patches.

What is then considered "obvious style issues" are today implemented
as errors / warnings in checkpatch for the most part. Not everyone
agrees with what checkpatch says are errors/warnings but this is at
least an more or less unambigious way to express these obvious cases.
And this is far better than the maintainers choice of the day style.

> Same for tabs versus spaces. That is something no human should
> need to care about. And it is something a machine can handle fine too 
> anyways.
Things turn red in my vi if no-one cares - and I have no magic tool
to fix it here.
No-one should submit patches with white-space errors - thank you.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/