linux-kernel - Re: [PATCH] PROC_FS: get and set the smp affinity of tasks by read-write /proc/<pid>/smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080104131340.6e2a26b6.pj@sgi.com>
Date:	Fri, 4 Jan 2008 13:13:40 -0600
From:	Paul Jackson <pj@....com>
To:	"rae l" <crquan@...il.com>
Cc:	akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	emdow@...ibm.com
Subject: Re: [PATCH] PROC_FS: get and set the smp affinity of tasks by
 read-write /proc/<pid>/smp_affinity

rael wrote:
> length check copied from kernel/irq/proc.c, now 'page' buffer couldn't
> be overrun,

Thanks.

> although Documentation/filesystems/proc.txt is heavily outdated,
> I'll add introduction of smp_affinity.

Good - my usual benchmark for documentation is that at least one place
in the code or associated documentation clearly describes things.

My main concern in this patch was that there were zero instances of
documentation of this new /proc file.  The patch should include a text
explanation of this feature, and put it somewhere.

Documentation/filesystems/proc.txt looked like a reasonable place, but
I don't really care where, nor do I lose as much sleep as I should when
some documentation is incomplete or stale.  Just so long as everything
is clearly explained somewhere.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.940.382.4214
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/