linux-kernel - Re: [PATCH 5/5] CONNECTOR: return proper error code in cn_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080105152449.GA12982@2ka.mipt.ru>
Date:	Sat, 5 Jan 2008 18:24:49 +0300
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	David Miller <davem@...emloft.net>
Cc:	lizf@...fujitsu.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback()

Hi.

Sorry for long reply.

On Fri, Jan 04, 2008 at 01:51:25AM -0800, David Miller (davem@...emloft.net) wrote:
> > Error code should be set to EINVAL instead of ENODEV if !queue_work().
> > There's another call of queue_work() which may set err to EINVAL.
> > 
> > Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> 
> This one is a bug fix so I'll apply it to net-2.6 and push
> to Linus.
> 
> The rest are cleanups which I'll queue up for 2.6.25

Although I'm not sure changing error from nodev to inval is a bug fix :),
I have no problem with pushing it first.
Loop above will break out after first matched id, so it will never call
the path, which can change error, again.

Thanks a lot for patches and quick merge!

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/