linux-kernel - Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478114F3.6020804@s5r6.in-berlin.de>
Date:	Sun, 06 Jan 2008 18:50:43 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Al Boldi <a1426z@...ab.com>
CC:	Sam Ravnborg <sam@...nborg.org>, Adrian Bunk <bunk@...nel.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Brownell <david-b@...bell.net>, Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

Al Boldi wrote:
> Stefan Richter wrote:
>> Al Boldi wrote:
>>>   	menuconfig USB_STORAGE
>>>   	tristate "USB Mass Storage support"
>>> -	depends on USB && SCSI
>>> +	depends on USB && BLOCK
>>> +	select SCSI
>> Still wrong. SCSI also needs HAS_DMA and SCSI_DMA.
> 
> I don't think so.  SCSI selects SCSI_DMA, it doesn't depend on it.

"A selects B" == "A depends on B, but please don't hide A when B is off
and silently switch B on when A is switched on".

config SCSI
	tristate "SCSI device support"
	depends on BLOCK
	select SCSI_DMA if HAS_DMA

So, SCSI doesn't actually need SCSI_DMA per se, but it apparently needs
it whenever HAS_DMA != n.

> So it's safe to select SCSI here, as libata does it the same way.

Sam, does kconfig recursively follow select statements and switch on
options which are select'ed by select'ed options?  I suppose it doesn't.

Maybe this would be better:

 config SCSI
 	tristate "SCSI device support"
 	depends on BLOCK
-	select SCSI_DMA if HAS_DMA

 config SCSI_DMA
 	bool
-	default n
+	default y if SCSI && HAS_DMA

-- 
Stefan Richter
-=====-==--- ---= --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/