linux-kernel - Re: [PATCH][SCSI] megaraid: Convert from "scsi.h" to <scsi.h> (and friends)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 Jan 2008 13:31:03 -0600
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Richard Knutsson <ricknu-0@...dent.ltu.se>
Cc:	megaraidlinux@....com, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH][SCSI] megaraid: Convert from "scsi.h" to <scsi.h> (and
	friends)


On Sun, 2008-01-06 at 20:03 +0100, Richard Knutsson wrote:
> Convert glue-include "scsi.h" to <scsi.h> (and friends).
> 
> (binary sizes)
> allyesconfig: before: 260132
>               after:  260048
> 
> allmodconfig: before: 261740
>               after:  261656
> 
> Signed-off-by: Richard Knutsson <ricknu-0@...dent.ltu.se>
> ---
> Do not have the hardware, but since it compiles I hope it is alright.
> 
> 
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index 66c6520..9f1e2c5 100644
> --- a/drivers/scsi/megaraid.c
> +++ b/drivers/scsi/megaraid.c
> @@ -48,8 +48,9 @@
>  #include <linux/dma-mapping.h>
>  #include <scsi/scsicam.h>
>  
> -#include "scsi.h"
> +#include <scsi/scsi_cmnd.h>
>  #include <scsi/scsi_host.h>
> +#include <scsi.h>

I'm afraid this is pretty much wrong.  The scsi.h being referred to here
is the local scsi.h in the build directory, so it should be included as
a string.  For #include, "..." means begin the search in the local
directory (what is wanted here) and <...> means begin the search
starting with the predefined include paths.

The rest of the patch looks like a spurious (unrelated and undescribed)
downcasing of TRUE and FALSE.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/