| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Jan 2008 01:30:49 +0300 From: Anton Vorontsov <cbouatmailru@...il.com> To: Dmitry <dbaryshkov@...il.com> Cc: linux-kernel@...r.kernel.org, cbou@...l.ru, dwmw2@...radead.org Subject: Re: [PATCH 1/3] power_supply: add few more values and props On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: [...] > > > + POWER_SUPPLY_ATTR(voltage_max), > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > I'd suggest keep Documentation/power_supply_class.txt in sync > > wrt new properties, to distinct their meanings and usage. > > > > I assume you're using these new properties for non-rechargeable > > LiMn batteries. So, why new properties, aren't voltage_*_design > > ones suits that purpose? If battery is non-rechargeable it is > > having only design values, no? > > No, I used it for the battery driver for Sharp Zaurus SL-6000 (tosa). > It's connected via simple ADC so I can get only voltages. I don't know > max_design value for the battery, but I have 'FULL' signal which I use > to detect 'voltage_max' and use it for power estimations. Ah, I see. In that case the value is empiric and voltage_max is appropriate name indeed. Thanks, -- Anton Vorontsov email: cbou@...l.ru backup email: ya-cbou@...dex.ru irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists