linux-kernel - Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Jan 2008 08:03:27 +0300
From:	Al Boldi <a1426z@...ab.com>
To:	Sam Ravnborg <sam@...nborg.org>, Adrian Bunk <bunk@...nel.org>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, David Brownell <david-b@...bell.net>,
	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

Sam Ravnborg wrote:
> On Sat, Jan 05, 2008 at 11:03:30PM +0200, Adrian Bunk wrote:
> > For kconfig users, "select" is _much_ better than sending them through
> > different menus.
>
> Only if used within the current limitations of Kconfig.
> And that requires you to use select only to select symbols with
> no dependencies.
>
> In this case we do not know if BLOCK is enabled or not.

Good point!  How about we solve it like this:

  	menuconfig USB_STORAGE
  	tristate "USB Mass Storage support"
-	depends on USB && SCSI
+	depends on USB && BLOCK
+	select SCSI


Thanks!

--
Al

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/