linux-kernel - Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m163y6ko1e.fsf@ebiederm.dsl.xmission.com>
Date:	Mon, 07 Jan 2008 02:01:01 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Peer Chen" <pchen@...dia.com>
Cc:	"peerchen" <peerchen@...il.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"akpm" <akpm@...ux-foundation.org>,
	"Andy Currid" <ACurrid@...dia.com>
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

"Peer Chen" <pchen@...dia.com> writes:

> Eric,
> Any decision for this patch, if not, currently we prefer to add all our
> code to quirks.c.

Sorry.  I think adding the code to quirks.c is fine.

For bisection and code inspection purposes I would prefer the code
to come as a patchset of two patches.  With the generic change
first.

I wanted to understand where you were coming from to make certain
I had not looked over something generic.  The closest to generic
I can make of your concern is that we are doing useless work if
we know there is an upstream msi to irq mapper that we can just
tunnel to over hypertransport.  At the generic level we can't know
that there is an upstream mapping capability as nothing reports
it, so we even if it is a good idea we can't do anything.

So a quirk looks fine to do what you are doing. 

Just please next round handle the address part of the msi mapping
capability if it is present, in the x86 part of the generic code.
Just in case someone implements that.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/