linux-kernel - Re: 2.6.24-rc7, intel audio: alsa doesn't say a beep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080108101024.GB6906@elte.hu>
Date:	Tue, 8 Jan 2008 11:10:24 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Harald Dunkel <harald.dunkel@...nline.de>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: 2.6.24-rc7, intel audio: alsa doesn't say a beep


* Takashi Iwai <tiwai@...e.de> wrote:

> > The only difference between rc6 and rc7 in sound/pci/hda/hda_intel.c is
> > this:
> > 
> > diff -ur linux-2.6.24-rc6/sound/pci/hda/hda_intel.c linux-2.6.24-rc7/sound/pci/hda/hda_intel.c
> > --- linux-2.6.24-rc6/sound/pci/hda/hda_intel.c	2007-12-21 02:25:48.000000000 +0100
> > +++ linux-2.6.24-rc7/sound/pci/hda/hda_intel.c	2008-01-06 22:45:38.000000000 +0100
> > @@ -555,7 +555,8 @@
> >   		}
> >   		if (!chip->rirb.cmds)
> >   			return chip->rirb.res; /* the last value */
> > -		schedule_timeout_uninterruptible(1);
> > +		udelay(10);
> > +		cond_resched();
> >   	} while (time_after_eq(timeout, jiffies));
> > 
> >   	if (chip->msi) {
> > 
> > 
> > Do you think this could be related to the problem?
> 
> Could you revert it and check whether the problem still exists?
> 
> I hardly believe it's the culprit, but if this is the only change in
> the sound subsystem...

lets revert it (commit 57a04513cb3) if it's causing problems. This patch 
sat in -mm for quite some time - so it seems -rc7 is getting pretty good 
test coverage.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/