linux-kernel - Re: [PATCH 04/16] per-cpu run guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Jan 2008 22:02:27 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
Cc:	lguest@...abs.org, glommer@...il.com, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, rostedt@...dmis.org
Subject: Re: [PATCH 04/16] per-cpu run guest

On Tuesday 08 January 2008 00:05:25 Glauber de Oliveira Costa wrote:
> +	/* Watch out for arbitrary vcpu indexes! */
> +	if (vcpu_id > lg->nr_vcpus)
> +		return -EINVAL;
> +
> +	vcpu = &lg->vcpus[vcpu_id];
> +

Out-by-one error here... Fixed it for you, plus a couple of others.

I've applied the patches, but made one minor-but-invasive change: I didn't 
want to ask you to spin the patches again!

I changed "vcpu" to "cpu" everywhere (the v is pretty redundant in this 
context), which cut about a dozen lines of code out (things now fitted 
again!).

I also changed "vcpu_id" to simply "id" and made it unsigned.  Do you plan for 
this to always be equal to the index in the vcpu array BTW?  If so, we can 
neaten vcpu_start (now lg_cpu_start)...

You can grab the latest now...

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/