linux-kernel - Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080108111549.GA30832@rain>
Date:	Tue, 8 Jan 2008 14:15:53 +0300
From:	Evgeniy Dushistov <dushistov@...l.ru>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3

On Sun, Nov 25, 2007 at 01:24:25PM +0200, James Bottomley wrote:
> This is a bit of a rash of bug fixes.  The qla1280 is actually a bug fix
> (in spite of the title---it's actually correcting an existing problem
> with the qla1280 implementation of accessors that broke the current
> driver).
> 

Recently I build last Linus's git tree, and got:
‘req_cnt’ is used uninitialized in this function,
and see bellow
> The patch is available here:
> 
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
> 
> The short changelog is:
...
> Jes Sorensen (1):
>       qla1280: convert to use the data buffer accessors
> 
...
>  scsi/qla1280.c         |  387 +++++++++++++++++++++----------------------------
...
>  	/* Calculate number of entries and segments required. */
> -	req_cnt = 1;
> 

Initilization of req_cnt was removed, but in this function
there are places like 
req_cnt += (seg_cnt - 4) / 7;
or
req_cnt++;
This is should be so?

-- 
/Evgeniy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/