linux-kernel - Re: [patch 2/2] track and print last unloaded module in the oops trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5eeb9ad90801080551n562b9f15o27b495495a452c22@mail.gmail.com>
Date:	Tue, 8 Jan 2008 14:51:37 +0100
From:	DM <dm.n9107@...il.com>
To:	"Arjan van de Ven" <arjan@...radead.org>
Cc:	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au, ak@...e.de,
	mingo@...e.hu
Subject: Re: [patch 2/2] track and print last unloaded module in the oops trace

On Jan 7, 2008 12:19 AM, Arjan van de Ven <arjan@...radead.org> wrote:
[...]
> This patch tracks the last unloaded module, and prints this as part of the
> module list in the oops trace.
>
[...]
>        }
> +       /* Store the name of the last unloaded module for diagnostic purposes */
> +       sprintf(last_unloaded_module, mod->name);
>        free_module(mod);
>

Why use sprintf? If a module name contains the % character we could
overflow the buffer. Or is module-unloading root-only and we don't
care?

Best regards,
dm.n9107
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/