linux-kernel - Re: [patch 2/2] track and print last unloaded module in the oops trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080108161846.GD32273@elte.hu>
Date:	Tue, 8 Jan 2008 17:18:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	DM <dm.n9107@...il.com>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au, ak@...e.de
Subject: Re: [patch 2/2] track and print last unloaded module in the oops
	trace


* DM <dm.n9107@...il.com> wrote:

> On Jan 8, 2008 3:26 PM, Arjan van de Ven <arjan@...radead.org> wrote:
> > >
> > > Why use sprintf? If a module name contains the % character we could
> > > overflow the buffer. Or is module-unloading root-only and we don't
> > > care?
> >
> > module loading isn't just root only; the name comes from an already loaded module.
> > If you can load kernel modules of your choice you own the entire kernel already anway
> >
> 
> Still, strcpy seems like a better choice IMHO.

agreed, this just isnt obvious IMO:

+       sprintf(last_unloaded_module, mod->name);

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/