linux-kernel - Re: [PATCH] Deprecate checkpatch.pl --file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1199811033.1756.29.camel@imap.mvista.com>
Date:	Tue, 08 Jan 2008 08:50:33 -0800
From:	Daniel Walker <dwalker@...sta.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, apw@...dowen.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] Deprecate checkpatch.pl --file


On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:


> +if ($file) {
> +	print <<EOL
> +WARNING: Using --file mode. Please do not send patches to linux-kernel
> +that change whole existing files if you did not significantly change most
> +of the the file for other reasons anyways or just wrote the file newly
> +from scratch. Pure code style patches have a significant cost in a
> +quickly changing code base like Linux because they cause rejects
> +with other changes.
> +If you're sure you want to use whole file mode please use --file-force
> +EOL
> +;
> +	exit(1);

Can't say I like this too much .. It sounds like your telling people to
stop sending cleanup patches, which doesn't make much sense .. We want a
clean kernel .. Or at least I do ..

Linus and Andrew could slow acceptable of these patches, but I don't
think discouraging people from cleaning up code and submitting a patch
for that is the right thing to do..

(Btw, I changed to akpm@...ux-foundation.org and not @osdl.org .. )

Daniel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/