linux-kernel - Re: [PATCH 3/5] x86: coding style fixes in arch/x86/ia32/ia32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080108195933.GB4627@martell.zuzino.mipt.ru>
Date:	Tue, 8 Jan 2008 22:59:33 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>, trivial@...nel.org
Subject: Re: [PATCH 3/5] x86: coding style fixes in arch/x86/ia32/ia32_aout.c

> -		if ((jiffies-error_time) > 5*HZ)
> -		{
> -			printk(KERN_WARNING 
> +		if ((jiffies-error_time) > 5*HZ) {

Should we expect second wave of this crap when you will suddenly realize
that it would be even nicer to write:

	if (jiffies - error_time > 5 * HZ) {

	Alexey "?" Dobriyan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/