linux-kernel - Re: [PATCH 4/5] x86: coding style fixes in arch/x86/ia32/ia32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d8e3fd30801081214v43294520h36e2da6df2bb3fe2@mail.gmail.com>
Date:	Tue, 8 Jan 2008 21:14:22 +0100
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Alexey Dobriyan" <adobriyan@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	"Ingo Molnar" <mingo@...e.hu>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>, trivial@...nel.org
Subject: Re: [PATCH 4/5] x86: coding style fixes in arch/x86/ia32/ia32_binfmt.c

On Jan 8, 2008 9:02 PM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> >  static void elf32_init(struct pt_regs *regs)
> >  {
> > -     struct task_struct *me = current;
> > +     struct task_struct *me = current;
> >       regs->rdi = 0;
> >       regs->rsi = 0;
> >       regs->rdx = 0;
> >       regs->rcx = 0;
> >       regs->rax = 0;
> > -     regs->rbx = 0;
> > -     regs->rbp = 0;
> > +     regs->rbx = 0;
> > +     regs->rbp = 0;
> >       regs->r8 = regs->r9 = regs->r10 = regs->r11 = regs->r12 =
> > -             regs->r13 = regs->r14 = regs->r15 = 0;
> > -    me->thread.fs = 0;
> > +             regs->r13 = regs->r14 = regs->r15 = 0;
> > +    me->thread.fs = 0;
> >       me->thread.gs = 0;
> > -     me->thread.fsindex = 0;
> > +     me->thread.fsindex = 0;
> >       me->thread.gsindex = 0;
> > -    me->thread.ds = __USER_DS;
> > +    me->thread.ds = __USER_DS;
>
> No re-indenting those 4-spaced lines? I mean if you're in CodindStyle
> compliance business driving from 99 to 99.9 percents please do it well
> at least.

Neither checkpatch.pl nor my .vimrc triggered those lines :-/

If Ingo wants to apply the patch I'll update it.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/