linux-kernel - Re: [PATCH 3/5] x86: coding style fixes in arch/x86/ia32/ia32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080108205149.GA26794@uranus.ravnborg.org>
Date:	Tue, 8 Jan 2008 21:51:49 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Rik van Riel <riel@...hat.com>
Cc:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>, trivial@...nel.org
Subject: Re: [PATCH 3/5] x86: coding style fixes in arch/x86/ia32/ia32_aout.c

On Tue, Jan 08, 2008 at 03:04:39PM -0500, Rik van Riel wrote:
> On Tue, 8 Jan 2008 20:32:33 +0100
> Paolo Ciarrocchi <paolo.ciarrocchi@...il.com> wrote:
> 
> > Fix plenty of coding style errors
> 
> Most of these kernel changes would probably get in the way of
> real development, making patches reject that would otherwise
> apply.
> 
> You did find one possible bug, though:
> 
> > @@ -467,9 +465,9 @@ static int load_aout_library(struct file *file)
> >  
> >  #ifdef WARN_OLD
> >  		static unsigned long error_time;
> > -		if ((jiffies-error_time) > 5*HZ)
> > -		{
> > -			printk(KERN_WARNING 
> > +		if ((jiffies-error_time) > 5*HZ) {
> > +
> > +			printk(KERN_WARNING
> >  			       "N_TXTOFF is not page aligned. Please convert library: %s\n",
> >  			       file->f_path.dentry->d_name.name);
> >  			error_time = jiffies;
> 
> You may want to look into the time_after() macro and make sure
> it is used here.

It is already fixed in the x86 tree in the mm branch.

So this part would conflict with ongoing development effort...

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/