linux-kernel - Re: [PATCH] x86_64: enable irq in default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080108221238.GB21482@elte.hu>
Date:	Tue, 8 Jan 2008 23:12:38 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	mingo@...hat.com, tglx@...utronix.de, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64: enable irq in default_idle


* Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:

> >> local_irq_enable() is missing after 
> >> sched_clock_idle_wakeup_event().
> > 
> > thanks Hiroshi, applied.
> > 
> > The effects of this bug should be increased latencies on 64-bit. Did 
> > you notice these latencies, or did you find the bug in some other 
> > way (code review)?
> 
> I found this when I was comparing 32-bit and 64-bit source code for 
> x86 unification.

cool :) Indeed even for other code, a number of times we got bugfixes 
when unifying 32-bit and 64-bit files.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/