linux-kernel - Re: [patch 03/19] define page_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0801081414230.4281@schroedinger.engr.sgi.com>
Date:	Tue, 8 Jan 2008 14:18:40 -0800 (PST)
From:	Christoph Lameter <clameter@....com>
To:	Rik van Riel <riel@...hat.com>
cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Lee Schermerhorn <lee.schermerhorn@...com>
Subject: Re: [patch 03/19] define page_file_cache() function

On Tue, 8 Jan 2008, Rik van Riel wrote:

> Define page_file_cache() function to answer the question:
> 	is page backed by a file?

> +static inline int page_file_cache(struct page *page)
> +{
> +	if (PageSwapBacked(page))
> +		return 0;

Could we call this PageNotFileBacked or so? PageSwapBacked is true for 
pages that are RAM based. Its a bit confusing.

> Index: linux-2.6.24-rc6-mm1/mm/migrate.c
> ===================================================================
> --- linux-2.6.24-rc6-mm1.orig/mm/migrate.c	2008-01-02 12:37:14.000000000 -0500
> +++ linux-2.6.24-rc6-mm1/mm/migrate.c	2008-01-02 12:37:22.000000000 -0500
> @@ -546,6 +546,8 @@ static int move_to_new_page(struct page 
>  	/* Prepare mapping for the new page.*/
>  	newpage->index = page->index;
>  	newpage->mapping = page->mapping;
> +	if (PageSwapBacked(page))
> +		SetPageSwapBacked(newpage);
>  
>  	mapping = page_mapping(page);
>  	if (!mapping)

That hunk belongs into migrate_page_copy()? Or is there a reason that we 
need this flag that early?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/