linux-kernel - Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7vir23jp3e.fsf@gitster.siamese.dyndns.org>
Date:	Wed, 09 Jan 2008 02:00:21 -0800
From:	Junio C Hamano <junio@...ox.com>
To:	Andi Kleen <andi@...stfloor.org>
cc:	Arnd Bergmann <arnd@...db.de>,
	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org, apw@...dowen.org
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Andi Kleen <andi@...stfloor.org> writes:

> I imagined it would check for 
>
> +struct file_operations ... = { 
> +      ...
> +	.ioctl = ...
>
> That wouldn't catch the case of someone adding only .ioctl to an 
> already existing file_operations which is not visible in the patch context, 
> but that should be hopefully rare. The more common case is adding
> completely new operations.

Because "diff -p" format used by the kernel mailing list takes
the most recent line that begins with an identifier letter and
put that on the hunk header line, even in such a case, you will
see:

	@@ -l,k +m,n @@ struct file_operations ... = {
		...
		...
	+	...
	+	.ioctl = ...
	+	...
		...

which would be a good enough cue that the new .ioctl member is
added to file_operations.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/