linux-kernel - Re: [PATCH] Change x86 Machine check handler to use unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Jan 2008 11:20:17 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Nikanth Karthikesan <knikanth@...e.de>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] Change x86 Machine check handler to use unlocked_iocl
	instead of ioctl


* Nikanth Karthikesan <knikanth@...e.de> wrote:

> The Machine check handler registers ioctl handler that is called with 
> the BKL held. Changing to register unlocked_ioctl instead. Also mce 
> ioctl handler does not seem to need any lock protection.
> 
> Change the Machine check handler to use unlocked_ioctl instead of 
> ioctl handler. Also the mce ioctl handler does not need any lock 
> protection.

thanks, applied to x86.git. Mcelog functionality uses cmpxchg so no need 
for the BKL there. The ioctl still being BKL is purely historic and it 
was never relied on.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/