lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Jan 2008 14:26:26 +0100 (CET) From: Jiri Kosina <jikos@...os.cz> To: Matthew Wilcox <matthew@....cx> cc: Nikanth Karthikesan <knikanth@...e.de>, grant@...que.net, tim@...erelk.net, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl On Wed, 9 Jan 2008, Matthew Wilcox wrote: > > default: > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd); > > + unlock_kernel(); > > return -EINVAL; > Surely a bug ... shouldn't this return -ENOTTY? What POSIX states [1]: [EINVAL] The request or arg argument is not valid for this device. [ENOTTY] The fildes argument is not associated with a STREAMS device that accepts control functions. [1] http://www.opengroup.org/onlinepubs/009695399/functions/ioctl.html -- Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists