linux-kernel - Re: uml and -regparm=3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Jan 2008 23:33:06 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	andi@...stfloor.org, harvey.harrison@...il.com, jdike@...toit.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: uml and -regparm=3

On Wed, Jan 09, 2008 at 10:20:49PM +0100, Miklos Szeredi wrote:
> > Miklos Szeredi <miklos@...redi.hu> writes:
> > 
> > > FASTCALL is defined empty in -mm, but UML is not compiled with
> > > -mregparm=3 and so this breaks things (I noticed problems with
> > > rwsem_down_write_failed).
> > >
> > > Tried recompiling UML with -mregparm=3, but that resulted in a strange
> > > failure immediately after startup:
> > >
> > > |%Gï¿½%@: Invalid argument
> > >
> > > What's up?
> > 
> > UML links with glibc and that does not use -mregparm. 
> > 
> > You can only use -mregparm in user space if you recompile
> > all libraries too.
> 
> Ah, right.  I didn't think of that.
> 
> Does that mean that FASTCALL removals will have to be undone?  Or is
> there an alternative?

It's enough when we keep fastcall/FASTCALL in the few cases where UML 
calls assembler code with this calling convention. [1]

> Miklos

cu
Adrian

[1] http://lkml.org/lkml/2007/12/4/425

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/