linux-kernel - Re: [PATCH] x86: trivial whitespace in kprobes.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jan 2008 06:06:50 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ibm.com>
Subject: Re: [PATCH] x86: trivial whitespace in kprobes.c

Masami Hiramatsu wrote:
> Harvey Harrison wrote:
>> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> 
> Acked-by: Masami Hiramatsu <mhiramat@...hat.com>
> 
>> ---
>> Ingo, you could/should probably fold this into Masami's kprobe
>> unification patch.
> 
> The original code had these whitespace, because (I think)
> kretprobe_trampoline_holder() had just hold a memory space
> for hooking function return. And now, it has actual code.

Hmm, this function still a bit special, because it is not
called directly. kretprobe uses kretprobe_trampoline symbol,
which is defined in this function.
Anyway, I think the whitespace does not help us understand it...

> So the whitespace can be removed.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com, masami.hiramatsu.pt@...achi.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/