linux-kernel - Re: [PATCH] x86: Remove ifdef from step.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080110124041.GA15156@elte.hu>
Date:	Thu, 10 Jan 2008 13:40:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: Remove ifdef from step.c


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> @@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct *child, unsigned long val)
>  	if (child != current)
>  		return;
>  
> -#ifdef CONFIG_X86_64
> -	wrmsrl(MSR_IA32_DEBUGCTLMSR, val);
> -#else
>  	wrmsr(MSR_IA32_DEBUGCTLMSR, val, 0);
> -#endif

doesnt this break 64-bit? 'val' is 64-bit, but wrmsr truncates it to 
32-bit? [while wrmsrl() kept the full 64 bits]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/