linux-kernel - Re: [vm] writing to UDF DVD+RW (/dev/sr0) while under memory pressure: box ==> doorstop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080110144123.GA12331@atrey.karlin.mff.cuni.cz>
Date:	Thu, 10 Jan 2008 15:41:23 +0100
From:	Jan Kara <jack@...e.cz>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Mike Galbraith <efault@....de>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [vm] writing to UDF DVD+RW (/dev/sr0) while under memory pressure: box ==> doorstop

> On Wed, 09 Jan 2008 12:11:20 +0100
> Mike Galbraith <efault@....de> wrote:
> 
> > 
> > On Tue, 2008-01-08 at 16:27 +0100, Mike Galbraith wrote:
> > > On Tue, 2008-01-08 at 16:21 +0100, Mike Galbraith wrote:
> > > > On Tue, 2008-01-08 at 03:38 -0800, Andrew Morton wrote:
> > > > > 
> > > > > Well.  From your earlier trace it appeared that something was causing
> > > > > the filesystem to perform synchronous inode writes - sync_dirty_buffer() was
> > > > > called.
> > > > > 
> > > > > This will cause many more seeks than would occur if we were doing full
> > > > > delayed writing, with obvious throughput implications.
> > > > 
> > > > Yes, with UDF, the IO was _incredibly_ slow.  With ext2, it was better,
> > > > though still very bad.  I tested with that other OS, and it gets ~same
> > > > throughput with UDF as I got with ext2 (ick).
> > > > 
> > > > UDF does udf_clear_inode() -> write_inode_now(inode, 1)
> > > > 
> > > > I suppose I could try write_inode_now(inode, 0).  Might unstick the box.
> > > 
> > > (nope, still sync, UDF still deadly)
> > 
> > write_inode_now() is a fibber.
> 
> Sure is.  Looks like it was busted by:
> 
> commit fa94396d2792f5093aab7cf66e1fc1da0c9fc442
> Author: akpm <akpm>
> Date:   Tue Feb 4 17:01:43 2003 +0000
> 
>     [PATCH] Remove unneeded code in fs/fs-writeback.c
>     
>     We do not need to pass the `wait' argument down to __sync_single_inode().
>     That information is now present at wbc->sync_mode.
>     
> 
> > The below seems to fix it in that writes dribbling to the DVD+RW at the
> > whopping 1 to 10 pages/sec I'm seeing no longer turn box into a
> > doorstop.  It's probably busted as heck.
> 
> The VFS change looks good.  Not sure about the UDF details.
> 
> > Think I'll cc linux-mm, and go find something safer to play with.
> > 
> > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> > index 0fca820..f1cce24 100644
> > --- a/fs/fs-writeback.c
> > +++ b/fs/fs-writeback.c
> > @@ -657,7 +657,7 @@ int write_inode_now(struct inode *inode, int sync)
> >  	int ret;
> >  	struct writeback_control wbc = {
> >  		.nr_to_write = LONG_MAX,
> > -		.sync_mode = WB_SYNC_ALL,
> > +		.sync_mode = sync ? WB_SYNC_ALL : WB_SYNC_NONE,
> >  		.range_start = 0,
> >  		.range_end = LLONG_MAX,
> >  	};
> > diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> > index 6ff8151..d1fc116 100644
> > --- a/fs/udf/inode.c
> > +++ b/fs/udf/inode.c
> > @@ -117,7 +117,7 @@ void udf_clear_inode(struct inode *inode)
> >  		udf_discard_prealloc(inode);
> >  		udf_truncate_tail_extent(inode);
> >  		unlock_kernel();
> > -		write_inode_now(inode, 1);
> > +		write_inode_now(inode, 0);
> >  	}
> >  	kfree(UDF_I_DATA(inode));
> >  	UDF_I_DATA(inode) = NULL;
> > 
> 
> WB_SYNC_* should die.
> 
> I wonder why UDF was doing a synchronous write in there.  In fact I wonder
> why it's writing the inode at all?  extN doesn't do that.  If for some
> reason it really does want to make the inode immediately reclaimable then
> simply shoving it down into the /dev/hda1 pagecache should be sufficient
> (ie: what you did)..
  Looking at the code, I think UDF change is correct. UDF has to call
write_inode_now() because by the time clear_inode() is called, inode is
already written by VFS and prepared to be freed. But then UDF modifies
it in udf_clear_inode() (removes preallocation) and for these changes to
get to disk you have to write the inode explicitely. 
  But there's really no need to wait on IO. We only have to copy all
data from inode structure into buffers and that happens even if we don't
wait on sync.

								Honza
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/