[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1199979101.4474.89.camel@nikanth-laptop.blr.novell.com>
Date: Thu, 10 Jan 2008 21:01:41 +0530
From: Nikanth Karthikesan <knikanth@...e.de>
To: Jiri Kosina <jikos@...os.cz>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>,
Matthew Wilcox <matthew@....cx>, grant@...que.net,
tim@...erelk.net, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of
ioctl
On Thu, 2008-01-10 at 16:01 +0100, Jiri Kosina wrote:
> On Wed, 9 Jan 2008, Alan Cox wrote:
>
> > > > > default:
> > > > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > > > > + unlock_kernel();
> > > > > return -EINVAL;
> > > > Surely a bug ... shouldn't this return -ENOTTY?
> > Agreed - ENOTTY.
>
> Just out of curiosity, where does POSIX happen to specify ENOTTY as the
> correct one for unimplemented ioctl?
>
The printk is also wrong, It should have been, Invalid ioctl for the
device
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists