linux-kernel - Re: [PATCH 0/7] convert semaphore to mutex in struct class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080110183917.GA20188@suse.de>
Date:	Thu, 10 Jan 2008 10:39:17 -0800
From:	Greg KH <gregkh@...e.de>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	James.Bottomley@...senpartnership.com, linux-scsi@...r.kernel.org,
	a.zummo@...ertech.it, peterz@...radead.org, cbou@...l.ru,
	linux-kernel@...r.kernel.org, David Brownell <david-b@...bell.net>,
	krh@...hat.com, stern@...land.harvard.edu,
	rtc-linux@...glegroups.com,
	spi-devel-general@...ts.sourceforge.net,
	linux1394-devel@...ts.sourceforge.net, dwmw2@...radead.org,
	davem@...emloft.net, jarkao2@...il.com
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class

On Thu, Jan 10, 2008 at 05:48:43PM +0800, Dave Young wrote:
> The patches are done on my side, please help to check. 

Along with all of the other comments from people, I have a few.

> This is the first one of the series about driver core changes. 
> If this one is accepted and there's no other problem I will post the others for maintainer's review (they need your comment and help because I don't know well about the specific driver logic).
> 
> Thanks a lot in advance.
> ---
> 
> 1. convert class semaphore to mutex.
> 2. add class iterater functions to encapsulate the detail of class devices/children list iterating :
> 	class_for_each_device
> 	class_find_device
> 	class_for_each_child
> 	class_find_child

No, please create 1 patch per type-of-change.

So in this case you would have a series of patches:
	1) add the class iterator functions
	2-n) convert the existing places in the kernel using the
	     class->semaphore to use the new iterator functions
	n+1) convert class semaphore to mutex, which should only touch
	     the driver core

That way everything builds along the way, and it's easy to understand
and review.

Oh, and please start a new thread when you create a new patch like this
so it doesn't get burried in people's inboxes...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/