linux-kernel - Re: [patch 07/11] PAT x86: pat-conflict resolution using linear list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jan 2008 20:13:08 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	venkatesh.pallipadi@...el.com
Cc:	ebiederm@...ssion.com, rdreier@...co.com,
	torvalds@...ux-foundation.org, gregkh@...e.de, airlied@...net.ie,
	davej@...hat.com, mingo@...e.hu, tglx@...utronix.de, hpa@...or.co,
	linux-kernel@...r.kernel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [patch 07/11] PAT x86: pat-conflict resolution using linear list

venkatesh.pallipadi@...el.com writes:
>  
>  	/* Reset the direct mapping. Can block */
> -	if (p->flags >> 20)
> -		ioremap_change_attr(p->phys_addr, p->size, 0);
> +	if (p->flags >> 20) {
> +		free_mattr(p->phys_addr, p->phys_addr + get_vm_area_size(p),
> +		           p->flags>>20);
> +		ioremap_change_attr(p->phys_addr, get_vm_area_size(p), 0);

If you really unmap all holes and forbid (or let it just return the
__va address) ioremap on anything mapped (which is probably ok) then
you can eliminate that completely.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/