linux-kernel - Re: [x86] list of style offenders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d8e3fd30801101447p699a61a1q802fdb769c2b9a71@mail.gmail.com>
Date:	Thu, 10 Jan 2008 23:47:08 +0100
From:	"Paolo Ciarrocchi" <paolo.ciarrocchi@...il.com>
To:	"Daniel Walker" <dwalker@...sta.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [x86] list of style offenders

On Jan 10, 2008 11:41 PM, Daniel Walker <dwalker@...sta.com> wrote:
>
> On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > On Jan 10, 2008 9:03 PM, Daniel Walker <dwalker@...sta.com> wrote:
> > >
> > >
> > > I was playing with checkpatch.pl ;) .. I made a list of style offenders
> > > inside the arch/x86/ sub-directory. I thought it might be helpful to
> > > prioritize any style clean ups that people might want to do for x86 ..
> > > OTOH some of these might show imperfections in checkpatch.pl .. Either
> > > way I thought it was interesting to review ..
> > >
> > > These are sorted by errors, then warnings.. I only included the first
> > > hundred files which includes about the top %30 of the list .. The
> > > kprobes_64.c error rate is a little miss-leading because several errors
> > > are found on a single line ..
> >
> > I just pulled
> > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm
> >
> > > ./arch/x86/math-emu/fpu_trig.c
> > >                 total: 649 errors, 11 warnings, 1845 lines checked
>
> Ok, looks like people have been busy .. I was using Linus's git, which
> was handy at the time I ran the test ..

Do you have a script aroung checkpatch.pl for collecting the statistics
you posted? If so, I can run it agains the x86 git tree and report the output.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/