[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47858DD9.8020007@redhat.com>
Date: Wed, 09 Jan 2008 22:15:37 -0500
From: Masami Hiramatsu <mhiramat@...hat.com>
To: Harvey Harrison <harvey.harrison@...il.com>
CC: Heiko Carstens <heiko.carstens@...ibm.com>,
Christoph Hellwig <hch@...radead.org>,
Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
Ananth N Mavinakayanahalli <ananth@...ibm.com>,
David Miller <davem@...emloft.net>, hskinnemoen@...el.com,
schwidefsky@...ibm.com, tony.luck@...el.com,
Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
David Wilder <dwilder@...ibm.com>, jkenisto@...ibm.com
Subject: Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault()
Harvey Harrison wrote:
> Use a central kprobe_handle_fault() inline in kprobes.h to remove
> all of the arch-dependant, practically identical implementations in
> avr32, ia64, powerpc, s390, sparc64, and x86.
>
> avr32 was the only arch without the preempt_disable/enable pair
> in its notify_page_fault implementation.
>
> This uncovered a possible bug in the s390 version as that purely
> copied the x86 version unconditionally passing 14 as the trapnr
> rather than the error_code parameter. s390 is changed to pass
> error_code in this patch.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
I tested it on x86-64.
Acked-by: Masami Hiramatsu <mhiramat@...hat.com>
Thank you!
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@...hat.com, masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists