linux-kernel - Re: Splice(): exports for module programmers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080111090621.GH6258@kernel.dk>
Date:	Fri, 11 Jan 2008 10:06:21 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Chris Smowton <cs448@....ac.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Splice(): exports for module programmers

On Fri, Jan 11 2008, Chris Smowton wrote:
> Just a couple of quick questions if anyone can shed light regarding 
> functions exported for modules relating to splice():
> 
> * Is there a particular reason why the useful helper __splice_from_pipe 
> is exported, but not the locking equivalent splice_from_pipe or its 
> equally useful helper splice_to_pipe?
> * Similarly is there anything wrong with exporting the generic 
> pipe-buffer operations (e.g. generic_pipe_buf_map) to save effort 
> writing modules which implement splice_read and splice_write?
> 
> Are these unexported because they are unstable and not yet considered 
> suitable for use, or simply because nobody's written a module that 
> splice()s yet?

The latter, I generally don't export things until they are used.
__splice_from_pipe() wasn't exported until some file systems grew they
own splice implementations.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/