linux-kernel - Re: [patch 05/19] split LRU lists into anon & file sets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080111110622.52604fdc@bree.surriel.com>
Date:	Fri, 11 Jan 2008 11:06:22 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Lee Schermerhorn <Lee.Schermerhorn@...com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [patch 05/19] split LRU lists into anon & file sets

On Fri, 11 Jan 2008 10:50:09 -0500
Lee Schermerhorn <Lee.Schermerhorn@...com> wrote:

> Again, my doing.  I agree that the calculation is a bit strange, but I
> wanted to "future-proof" this function in case we ever get to a value of
> '6' for the lru_list enum.  In that case, the AND will evaluate to
> non-zero for what may not be a file LRU.  Between the build time
> assertion and the division [which could just be a 'l >> 1', I suppose]
> we should be safe.

Good point.  I did not guess that.

I'll restore the code to your original test.

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/