linux-kernel - Re: [PATCH] bluetooth : rfcomm tty BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080110.222320.247508342.davem@davemloft.net>
Date:	Thu, 10 Jan 2008 22:23:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hidave.darkstar@...il.com
Cc:	marcel@...tmann.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, bluez-devel@...ts.sourceforge.net
Subject: Re: [PATCH] bluetooth : rfcomm tty BUG_ON() code fix

From: Dave Young <hidave.darkstar@...il.com>
Date: Mon, 7 Jan 2008 13:41:22 +0800

> 1) In tty.c the BUG_ON at line 115 will never be called, because the the before list_del_init in this same function.
>  115          BUG_ON(!list_empty(&dev->list));
> So move the list_del_init to rfcomm_dev_del 
> 
> 2) The rfcomm_dev_del could be called from diffrent path (rfcomm_tty_hangup/rfcomm_dev_state_change/rfcomm_release_dev),
> So add another BUG_ON when the rfcomm_dev_del is called more than one time.
> 
> Signed-off-by: Dave Young <hidave.darkstar@...il.com> 

Applied, thanks Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/