linux-kernel - Re: [PATCH] kconfig: multibyte character support for lxdialog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080112135847.GA3580@uranus.ravnborg.org>
Date:	Sat, 12 Jan 2008 14:58:47 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	EGRY Gabor <gaboregry1@...nline.hu>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kernel@...kernel.org
Subject: Re: [PATCH] kconfig: multibyte character support for lxdialog

On Sat, Jan 12, 2008 at 01:01:55PM +0100, EGRY Gabor wrote:
> 
> UTF-8 support for lxdialog with wchar. The installed wide ncurses (ncursesw) is optional.

Building this on my 64 bit box with ncursesw support I saw several warnings.
Adding the following to dialog.h decreased the number:
#ifdef USE_WIDE_CURSES
#define _XOPEN_SOURCE_EXTENDED
#endif

But it was not warning free.

In addition in your patch below you assume that
ncurses wide char support and wide char support follows each other.
This assumption makes things overly complicated.

Can we assume we have wide char support everywhere today where
we will support building Linux?
I am mostly concerned about sun, cygwin and MingW here...

If we can assume wide char support everywhere your patch will
become simplerAnd adding wide char support should be a separate step.

I tried to take a look at varous source packages and they do not
need this long list of redefinitions of the ncurses functions.
Do we do something fundamentally different than for example
dialog since this indirection is needed?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/