linux-kernel - Fwd: Issue with arm-devel tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080112145449.GA11341@flint.arm.linux.org.uk>
Date:	Sat, 12 Jan 2008 14:54:49 +0000
From:	Russell King <rmk@....linux.org.uk>
To:	Lucas Woods <woodzy@...il.com>,
	Andre Haupt <andre@...wigglers.org>,
	Michael-Luke Jones <jonesml@...tmail.to>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel List <linux-kernel@...r.kernel.org>
Subject: Fwd: Issue with arm-devel tree

It might be a good idea if there was some co-ordination with people
involved in the duplicate include removal work...

    [ARM] remove duplicate includes
    
    Signed-off-by: Lucas Woods <woodzy@...il.com>
    Acked-by: Lennert Buytenhek <buytenh@...tstofly.org>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>

@@ -20,7 +20,6 @@
 #include <linux/module.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
-#include <linux/reboot.h>
 
 #include <asm/mach-types.h>


    [ARM] ixp4xx: remove double include
    
     Remove double include.
    
    Signed-off-by: Andre Haupt <andre@...wigglers.org>
    Signed-off-by: Alessandro Zummo <a.zummo@...ertech.it>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>

@@ -18,7 +18,6 @@
  */
 
 #include <linux/module.h>
-#include <linux/reboot.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/reboot.h>

I've dropped the "ixp4xx: remove double include" commit and fixed the
resulting breakage of "remove duplicate includes" change to resolve this
problem.

----- Forwarded message from Michael-Luke Jones <jonesml@...tmail.to> -----

To: rmk@....linux.org.uk
From: Michael-Luke Jones <jonesml@...tmail.to>
Subject: Issue with arm-devel tree
Date: Sat, 12 Jan 2008 14:23:44 +0000

http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/arm:devel.mbox

contains two patches:

"Re: [ARM] remove duplicate includes" from Lucas Woods  
<woodzy@...il.com>
"Re: [ARM] ixp4xx: remove double include" from Andre Haupt  
<andre@...wigglers.org>

which between the two of them manage to delete *both* instances of  
#include <linux/reboot.h> in nslu2-power.c

Given that nslu2-power.c calls machine_power_off() and ctrl_alt_del()  
this probably isn't a good thing.

Michael-Luke Jones

----- End forwarded message -----

-- 
Russell King
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/