linux-kernel - Re: [PATCH] 8390: split up 8390 with ISA delay and 8390 without

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080112001711.08361cd8@lxorguk.ukuu.org.uk>
Date:	Sat, 12 Jan 2008 00:17:11 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Zachary Amsden <zach@...are.com>
Cc:	jeff@...zik.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 8390: split up 8390 with ISA delay and 8390 without

> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c linux-2.6.24-rc6-mm1/drivers/net/hp.c
> > --- linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c	2008-01-02 16:04:00.000000000 +0000
> > +++ linux-2.6.24-rc6-mm1/drivers/net/hp.c	2008-01-11 14:47:44.000000000 +0000
> 
> > @@ -176,7 +176,7 @@
> >  				outb_p(irqmap[irq] | HP_RUN, ioaddr + HP_CONFIGURE);
> >  				outb_p( 0x00 | HP_RUN, ioaddr + HP_CONFIGURE);
> 
> ... didn't you miss two here?  Otherwise, code looks great.

The patch only changes the _p usage within the shared library. The hp.c
code is used solely by the ISA HP driver and needed.

> How will the user know when they need to use 8390p?  

They don't need to, any more than they need to know about 8390 right now.
It is added to the Makefile so will be sucked in and built by Make as an
extra module. The 8390p and 8390 use different wrapper symbols for
ei_open etc so depmod will load the right one.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/