linux-kernel - Re: 2.6.24-rc7-rt1: macro "put_cpu_var" passed 2 arguments, but takes just 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801132053.22830.m.kozlowski@tuxland.pl>
Date:	Sun, 13 Jan 2008 20:53:21 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	RT <linux-rt-users@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: 2.6.24-rc7-rt1: macro "put_cpu_var" passed 2 arguments, but takes just 1

Hello,

> We are pleased to announce the 2.6.24-rc7-rt1 tree, which can be
> downloaded from the location:
> 
>   http://rt.et.redhat.com/download/

  CC      arch/x86/mm/init_32.o
In file included from include/asm-generic/tlb.h:17,
                 from include/asm/tlb.h:9,
                 from arch/x86/mm/init_32.c:43:
include/linux/quicklist.h:73:28: error: macro "put_cpu_var" passed 2 arguments, but takes just 1
In file included from include/asm-generic/tlb.h:17,
                 from include/asm/tlb.h:9,
                 from arch/x86/mm/init_32.c:43:
include/linux/quicklist.h: In function '__quicklist_free':
include/linux/quicklist.h:73: error: 'put_cpu_var' undeclared (first use in this function)
include/linux/quicklist.h:73: error: (Each undeclared identifier is reported only once
include/linux/quicklist.h:73: error: for each function it appears in.)
make[1]: *** [arch/x86/mm/init_32.o] Error 1
make: *** [arch/x86/mm] Error 2

--- linux-2.6.24-rc7-rt1.orig/include/linux/quicklist.h 2008-01-11 21:16:22.000000000 -0500
+++ linux-2.6.24-rc7-rt1/include/linux/quicklist.h      2008-01-11 21:18:08.000000000 -0500
@@ -18,7 +18,7 @@ struct quicklist {
        int nr_pages;
 };

[... snip ...]

@@ -56,12 +64,13 @@ static inline void __quicklist_free(int 
        struct page *page)
 {
        struct quicklist *q;
+       int cpu;

-       q = &get_cpu_var(quicklist)[nr];
+       q = &get_cpu_var_locked(quicklist, &cpu)[nr];
        *(void **)p = q->page;
        q->page = p;
        q->nr_pages++;
-       put_cpu_var(quicklist);
+       put_cpu_var(quicklist, cpu); <------------- should that be put_cpu_var_locked()?
 }

Regards,

	Mariusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/