lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080114131429.40453e5f@siona>
Date:	Mon, 14 Jan 2008 13:14:29 +0100
From:	Haavard Skinnemoen <hskinnemoen@...el.com>
To:	"Mike Frysinger" <vapier.adi@...il.com>
Cc:	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Marc Pignat" <marc.pignat@...s.ch>, wim@...ana.be,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC, PATCH] watchdog on gpio

On Mon, 14 Jan 2008 04:45:25 -0500
"Mike Frysinger" <vapier.adi@...il.com> wrote:

> there is no hard requirement anywhere that says platform resources
> must be in the board resources file.  marking the functions as __init
> instead of __devinit will basically cause a kernel crash if someone
> tries to use dynamic platform resources.  there is no option that i'm
> aware of that prevents dynamic platform resources which means there is
> no way for the driver to say "i wont work with standard dynamic
> platform resources".

There is: platform_driver_probe(). It takes the probe function as a
parameter so that it can be left out of the platform_driver struct.
After it returns, there are no references to the probe function left
around, so if you call platform_driver_probe() instead of
platform_driver_register(), the probe function can be __init.

I agree that the driver is not safe in its current form.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ