linux-kernel - Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478B7C4A.5090903@gmail.com>
Date:	Mon, 14 Jan 2008 16:14:18 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	Paul Gortmaker <p_gortmaker@...oo.com>,
	LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

On 01/14/2008 07:38 AM, Cyrill Gorcunov wrote:
> This patch converts ioctl call to unlocked_ioctl form. It's possible
> due to rtl_lock spinlock protection.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> ---
> The patch is *not* tested but the patch does not bring _much_ changes
> so it wouldn't break the compilation procedure.
> 
> If there is problem with attachment - i could send it as inline
> form today evening.

Yes, please, especially if it is app/octet-stream (base64 encoded plaintext). 
Also Cc akpm or somebody who will pick your patch up.

> Andi, Jiri, Alexey the only thing I do complain about -
> is time set/read from several user threads that uses same
> (duplicated) file descriptor. Could there be useless thread
> spins instead of sleep (in case if this unlocked_ioctl were
> protected by mutex)?

Sorry, what?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/